search

hats-finance / Convergence-Finance---IBO-0x0e410e7af8e70fc5bffcdbfbdf1673ee7b3d0777

IBO, Vesting & Bond mecanism repo prepared for Hat finance audit competition
0 stars 0 forks source link

VestingCvg:: Strongly recommend to not have a floating pragma, and definitely not when the solidity version is as old as 0.8.0. #79

Open hats-bug-reporter[bot] opened 9 months ago

hats-bug-reporter[bot] commented 9 months ago

Github username: @dappconsulting Submission hash (on-chain): 0x4715dd84c9467516aa9f1e8d34064ab3ff75d0e172e9d838c64f2220219f6a12 Severity: low

Description: Description\ VestingCvg:: Strongly recommend to not have a floating pragma, and definitely not when the solidity version is as old as 0.8.0.

Future versions could have unexpected incompatibilities/dependencies which could have unforeseen consequences/issues on the protocol's functioning.

https://github.com/Cvg-Finance/hats-audit/blob/b5bb4d8022a2c71e255b620f8d636caef0dec731/contracts/PresaleVesting/VestingCvg.sol#L12

Current: pragma solidity ^0.8.0;

Recommendation: pragma solidity 0.8.20;

OR

If must use floating pragma: pragma solidity ^0.8.20;

Attack Scenario\ Future versions could have unexpected incompatibilities/dependencies which could have unforeseen consequences/issues on the protocol's functioning.

Attachments

  1. Proof of Concept (PoC) File

  2. Revised Code File (Optional)

shalbe-cvg commented 9 months ago

Hello, Thanks a lot for your attention.

This issue has already been reported in a previous issue, please check it: https://github.com/hats-finance/Convergence-Finance---IBO-0x0e410e7af8e70fc5bffcdbfbdf1673ee7b3d0777/issues/6

We have so to consider this issue as Invalid.