search

hats-finance / Convergence-Finance---IBO-0x0e410e7af8e70fc5bffcdbfbdf1673ee7b3d0777

IBO, Vesting & Bond mecanism repo prepared for Hat finance audit competition
0 stars 0 forks source link

VestingCvg::constructor() - Recommended to emit events for state variables in constructor that can/will be changed later again, as well as should emit events in all functions that change state. #81

Open hats-bug-reporter[bot] opened 1 year ago

hats-bug-reporter[bot] commented 1 year ago

Github username: @dappconsulting Submission hash (on-chain): 0x4715dd84c9467516aa9f1e8d34064ab3ff75d0e172e9d838c64f2220219f6a12 Severity: low

Description: Description\

VestingCvg::constructor() - Recommended to emit events for state variables in constructor that can/will be changed later again, as well as should emit events in all functions that change state.

https://github.com/Cvg-Finance/hats-audit/blob/b5bb4d8022a2c71e255b620f8d636caef0dec731/contracts/PresaleVesting/VestingCvg.sol#L81-L91

Attack Scenario\ N/A

Attachments

  1. Proof of Concept (PoC) File

  2. Revised Code File (Optional)

0xR3vert commented 1 year ago

Hello, Thanks a lot for your attention. In the VestingCvg constructor we simply set the presales & ibo addresses, theses addresses won't change later, so there is no need to emit an event for that. In conclusion we have so to consider this issue as invalid.