VotingEscrowUpgradeableV1_2: Missing emission of events while manipulating the critical state - `team` role transfer and all the `team` role based functions #24
Events allow capturing the changed parameters so that off-chain tools/interfaces can register such changes with timelocks that allow users to evaluate them and consider if they would like to engage/exit based on how they perceive the changes as affecting the trustworthiness of the protocol or profitability of the implemented financial services.
Missing events do not promote transparency and such changes immediately affect users’ perception of fairness or trustworthiness, they could exit the protocol causing a reduction in liquidity which could negatively impact protocol TVL and reputation.
Recommendation\
Emit events in all the mentioned functions
Github username: @burhankhaja Twitter username: imaybeghost Submission hash (on-chain): 0xf6316c806700ab6dd267254cf0f7aeb1fcb1d7fe651572685ba87cb2f6fb5b5b Severity: low
Description: while changing the
team
address and all the setter functions callabe by theteam
role, the contract doesn't emit events.functions:
why emit events ?
Recommendation\ Emit events in all the mentioned functions