hats-finance / Fenix--0x9d7765a7ebd5b6322a30797a44a5428531970d3d

0 stars 1 forks source link

Protocol will not be able to set claimable yield as intended #37

Open hats-bug-reporter[bot] opened 2 months ago

hats-bug-reporter[bot] commented 2 months ago

Github username: @ArnieGod Twitter username: arniesec Submission hash (on-chain): 0x6f601c429f53e6ccc2d29a0319a0a48b505381278ccce25d8fb5ee2ea4044e08 Severity: high

Description: Description\ In the Known issues tab the protocol states that they intend to have Rebasing erc20 yield as claimable by default, the problem is that the default yield mode of USDB and WETH is not claimbable, it is automatic.

the only way to change the yield mode is to call the configure function on both tokens and set the yield mode to AUTOMATIC. there exists no call to the configure function and so it is impossible to set claimable yield as intended by the protocol.

from blast docs:

However, unlike ETH where contracts have Disabled yield by default, WETH and USDB accounts have Automatic yield by default for both EOAs and smart contracts.

Users can change the yield mode of their WETH and USDB accounts by calling the configure function on the relevant token address.

Impact

the protocol will not be able to claim the rebasing token yield and its value will leak into the contract because of the default automatic yield mode.

ArnieSec commented 2 months ago

From known issues

Operation of v2 Pair with rebasing tokens from Blast - The implementation does not anticipate normal operation with these tokens in terms of configuration with automatic balance increase, so there is a possibility to configure these tokens during pair creation, by default, this will be Claimable mode.

ArnieSec commented 2 months ago

Actually I think this is invalid, the protocol can configure to claimable. My bad :/

0xmahdirostami commented 1 month ago

Thanks