search

hats-finance / Fenix-Finance-0x83dbe5aa378f3ce160ed084daf85f621289fb92f

0 stars 0 forks source link

Wrong function visibility #6

Open hats-bug-reporter[bot] opened 6 months ago

hats-bug-reporter[bot] commented 6 months ago

Github username: @https://github.com/Pavel2202 Twitter username: https://twitter.com/timenov_pavel Submission hash (on-chain): 0x41f85be2a77bc3d8a136389d805b22da011dfb6a71e7ed54dcd4a1d1bbe87e6c Severity: low

Description: Description\ In BribeUpgradeable.sol there is a view function earnedWithTimestamp that returns the earned amount given address and reward token, returns the rewards and the last user timestamp. This function is private, but should be marked as public.

earned amount given address and reward token, returns the rewards and the last user timestamp

Attack Scenario\ Describe how the vulnerability can be exploited.

Attachments

  1. Proof of Concept (PoC) File

  2. Revised Code File (Optional)

BohdanHrytsak commented 6 months ago

Thank you for the submission.

  1. This function is inherited and is in the contracts from Thena & Chronos, and is not affected by our changes, which makes it OOS
  2. The private access modifier was intended from the beginning, although it does seem illogical, and there are no problems or advantages to making it public