Hardcoded arbitrator evidence timeout for disputes might be too strict depending on the context

[hats-bug-reporter[bot]]

Github username: @aviggiano Submission hash (on-chain): 0x9fd7c43ba38664ca6fb0a5b0ff8c7549f64ffd04849f4ae9d7a4b54ece51c1ad Severity: low

Description: Description

In HATArbitrator.sol, a 24h timeout is set to add additional evidence for a dispute.

https://github.com/hats-finance/HATs-Arbitration-Contracts-0x79a618f675857b45934ca1c413fd5f409cf89735/blob/develop/contracts/HATArbitrator.sol#L137

The problem is that this timeout might be too strict depending on the use case. For example, suppose the committee requires additional evidence to substantiate the impact of a report disputed by a whitehat. Depending on the complexity of the analysis, this can take from hours to days.

As a result, some disputes might be ineffective if there's not enough time to submit additional evidence.

Recommendation

Increase the 24h timeout to at least 48h or, preferably, make this a configurable parameter by the HATArbitrator owner.

[bahurum]

Agree that 24 h could be too short for everyone that wishes to dispute. In particular, someone could use this to intentionally challenge with a false dispute and leave only 24 h for other disputers, who could miss this delay

[jellegerbrandy]

The 24 hour period is maximum time to add bonds to the dispute. The actual process of finding evidence is not something that necessarily happens on-chain (and the committee responsible for resolving the dispute is free to contact the whitehat by mail for further evidence, and wait some days (and un any case more than 24 hours) before resolving the dispute)