hats-finance / HATs-Arbitration-Contracts-0x79a618f675857b45934ca1c413fd5f409cf89735

MIT License
0 stars 0 forks source link

Use Ownable2Step rather than Ownable #71

Open hats-bug-reporter[bot] opened 8 months ago

hats-bug-reporter[bot] commented 8 months ago

Github username: @saidqayoumsadat Submission hash (on-chain): 0x01084ca89022df2e567180e61d19471e12a796e4ee32eeda9c6cd4ed1cdac698 Severity: low

Description: Description Ownable2Step and Ownable2StepUpgradeable prevent the contract ownership from mistakenly being transferred to an address that cannot handle it (e.g. due to a typo in the address), by requiring that the recipient of the owner permissions actively accept via a contract call of its own.

file: /contracts/nft/HATVaultsNFT.sol

19   contract HATVaultsNFT is ERC1155, Ownable {

https://github.com/hats-finance/hats-contracts/blob/0d6ebbde912bc272d9b310140d434ee2aacd36d3/contracts/nft/HATVaultsNFT.sol#L19

file: /contracts/tokenlock/TokenLock.sol

33    abstract contract TokenLock is Ownable, ITokenLock {

https://github.com/hats-finance/hats-contracts/blob/0d6ebbde912bc272d9b310140d434ee2aacd36d3/contracts/tokenlock/TokenLock.sol#L33

file: /contracts/tokenlock/TokenLockFactory.sol

18   contract TokenLockFactory is ITokenLockFactory, Ownable {

https://github.com/hats-finance/hats-contracts/blob/0d6ebbde912bc272d9b310140d434ee2aacd36d3/contracts/tokenlock/TokenLockFactory.sol#L18

file: /contracts/HATArbitrator.sol

13   contract HATArbitrator is IHATArbitrator, Ownable {

https://github.com/hats-finance/hats-contracts/blob/0d6ebbde912bc272d9b310140d434ee2aacd36d3/contracts/HATArbitrator.sol#L13

file: /contracts/HATGovernanceArbitrator.sol

9   contract HATGovernanceArbitrator is Ownable {

https://github.com/hats-finance/hats-contracts/blob/0d6ebbde912bc272d9b310140d434ee2aacd36d3/contracts/HATGovernanceArbitrator.sol#L9

jellegerbrandy commented 8 months ago

duplicate of #10