search

hats-finance / HATs-Arbitration-Contracts-0x79a618f675857b45934ca1c413fd5f409cf89735

MIT License
0 stars 0 forks source link

External calls in an un-bounded for-loop may result in a DOS #72

Open hats-bug-reporter[bot] opened 8 months ago

hats-bug-reporter[bot] commented 8 months ago

Github username: @saidqayoumsadat Submission hash (on-chain): 0x01084ca89022df2e567180e61d19471e12a796e4ee32eeda9c6cd4ed1cdac698 Severity: low

Description: Description

Consider limiting the number of iterations in for-loops that make external calls

file: /contracts/mocks/PoolsManagerMock.sol

25   (address vault, ) = _hatVaults.createVault(
                                IHATVault.VaultInitParams({
                                    asset: _assets[i],
                                    name: "VAULT",
                                    symbol: "VLT",
                                    rewardControllers: _rewardControllers,
                                    owner: _hatVaults.owner(),
                                    isPaused: false,
                                    descriptionHash: _descriptionHash
                                }),
                                IHATClaimsManager.ClaimsManagerInitParams({
36                                    owner: _hatVaults.owner(),

54            _rewardController.setAllocPoint(address(_hatVaults[i]), _allocPoint);

https://github.com/hats-finance/hats-contracts/blob/0d6ebbde912bc272d9b310140d434ee2aacd36d3/contracts/mocks/PoolsManagerMock.sol#L25-L36