search

hats-finance / Intuition-0x538dbadc50cc87b281cd655f1edbc6ebda02a66a

The smart contracts of the Intuition protocol v1.
https://intuition.systems
Other
0 stars 1 forks source link

scheduled operations can not be executed due to missing functionality #20

Open hats-bug-reporter[bot] opened 3 months ago

hats-bug-reporter[bot] commented 3 months ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0xf8e7e485d8e8e9727d552b27d7e06bb93ea1db631c51228ae6b09fab2fed0bd6 Severity: medium

Description: Description\ EthMultiVault.sol has implemented scheduleOperation() function which is used to schedule an operation to be executed after a delay.

    function scheduleOperation(bytes32 operationId, bytes calldata data) external onlyAdmin {

and cancelOperation() function which is used to cancel an scheduled operation.

However, all the scheduled operations can not be executed as the `EthMultiVault.sol does not have executeOperation() function to execute all the operations.

Openzeppelin's execute() can be checked here which does similar functionalities i.e executes single operations for given operationId.

Recommendations\ Add executeOperation() function to execute the operations which were successfully scheduled.

mihailo-maksa commented 3 months ago

This report is invalid due to the following reasons:

  1. Intended Functionality: The current implementation intentionally limits the scope of scheduled operations to setAdmin and setExitFee. This design choice ensures simplicity and security in managing critical functions.
  2. Future Extensions: We have the flexibility to extend the functionality to other operations as needed. The current setup allows us to manage the protocol efficiently and securely.

In conclusion, the contract works as intended, and the limited scope of scheduled operations is a deliberate design choice. Therefore, this issue is invalid.