hats-finance / Intuition-0x538dbadc50cc87b281cd655f1edbc6ebda02a66a

The smart contracts of the Intuition protocol v1.
https://intuition.systems
Other
0 stars 1 forks source link

Vault deposit are not checked with `maxDeposit()` due to missing functionality #67

Open hats-bug-reporter[bot] opened 4 days ago

hats-bug-reporter[bot] commented 4 days ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0xf7a015f3ddf4340c4b05c50a50ed383c0990d8ac664a64fdd0e0f799156cf447 Severity: low

Description: Description\

Based on Intuition documentation, EthMultiVault.sol conforms to EIP-4626 standard.

Conforming to the ERC4626 Tokenized Vault Standard, we extend the functionality to our MultiVault standard.

Intuition extends the ERC-4626 standard with the EthMultiVault.Sol contract

Check this reference.

This issue is with deposit() functions like depositAtom() and depositTriple() functions. There is no maximum deposit function in EthMultiVault.sol contract but there is maxRedeem() function which is incompliance with EIP-4626.

maxDeposit() is requirement of EIP4626 which is used as a maximum amount of the underlying asset that can be deposited into the Vault for the receiver, through a deposit call i.e with depositAtom() and depositTriple() functions.

Recommendation to fix\

Consider implementing maxDeposit() function and check the receiver deposits in both depositAtom() and depositTriple().