search

hats-finance / Metrom-0xfdfc6d4ac5807d7460da20a3a1c0c84ef2b9c5a2

Smart contracts for the Metrom project.
GNU General Public License v3.0
0 stars 0 forks source link

There is no way to recover upgradability back after using ossify() #39

Open hats-bug-reporter[bot] opened 6 months ago

hats-bug-reporter[bot] commented 6 months ago

Github username: -- Twitter username: @flyingBird_246 Submission hash (on-chain): 0xba1576f3560a185af3575e0e4e6ae3b9d797227d236bc0d127927d88a5b79efd Severity: low

Description: Description\ The Metrom.sol contract is initially constructed to be upgradable until the owner decides to alter that by calling ossify(). What if it turned out to be important to make an upgrade ( by the same owner or a new one) then the protocol will need to deploy another contract with the hassle of migrating the existing users into it.

Attachments

  1. Proof of Concept (PoC) File

  2. Revised Code File (Optional) The fix proposed is in the attached file L94-98

Files:

luzzif commented 6 months ago

This is wanted. The ossify function is explicitly put there to remove upgradeability once the Metrom protocol is mature enough and it's completely under control of the owner.