Inconsistent indexing of event fields in IMetrom.sol interface

[hats-bug-reporter[bot]]

Github username: -- Twitter username: -- Submission hash (on-chain): 0x7f1849ac938e5b738d81d047894751df67cbd187affbb5586eb98c081b5ac659 Severity: low

Description: Description

Indexed event fields make the field more quickly accessible to off-chain tools that parse events. This is especially useful when it comes to filtering based on some specific argument.

Wherever applicable, each event should use three indexed fields (maximum allowed by Solidity) if there are three or more fields. If there are fewer than three applicable fields, all of the applicable fields should be indexed.

Attack Scenario

Event fields defined in the IMetrom.sol interface though are not indexed consistently.

For example, event ClaimFee here only indexes one field instead of three while some other events index only two fields.

The same applies for all events that should be indexed as described in the description section above.

Attachments

https://github.com/hats-finance/Metrom-0xfdfc6d4ac5807d7460da20a3a1c0c84ef2b9c5a2/blob/e9d6b1e594d5bb3694bfe68f73399156ebb5d3a4/src/IMetrom.sol#L175

Revised Code File (Optional)

Consider indexing event fields as described in the description section above.

[luzzif]

This is below the low level imho and not a real vulnerability, that's why I marked it as invalid.