search

hats-finance / Most--Aleph-Zero-Bridge-0xab7c1d45ae21e7133574746b2985c58e0ae2e61d

Aleph Zero bridge to Ethereum
Apache License 2.0
0 stars 1 forks source link

Fee-on-transfer Tokens Incompatible with `eth::most` #1

Open hats-bug-reporter[bot] opened 5 months ago

hats-bug-reporter[bot] commented 5 months ago

Github username: @0xmahdirostami Twitter username: 0xmahdirostami Submission hash (on-chain): 0x80a6c6a2034a5ecaf904b8e915a87b91afe95d35e590eea2ba9f8d3e06f6a80e Severity: medium

Description: Description\ The sendRequest function transfers tokens from msg.sender. However, some tokens implement fee-on-transfer mechanisms, which means they don't transfer the actual amount specified. This inconsistency can cause sendRequestNative transactions to revert later on.

Impact\ Denial-of-Service (DoS) vulnerability in the sendRequestNative function.

Revised Code File (Optional)\ Calculate the transferred amount based on the balance before and after the transfer.

krzysztofziobro commented 5 months ago

Invalid submission: A PoC is required for submission to be considered valid. You can create a new submission that contains a working PoC.