hats-finance / Most--Aleph-Zero-Bridge-0xab7c1d45ae21e7133574746b2985c58e0ae2e61d

Aleph Zero bridge to Ethereum
Apache License 2.0
0 stars 1 forks source link

The Upgraded `new_address` itself cannot be upgraded. Stucked in use forever #41

Open hats-bug-reporter[bot] opened 5 months ago

hats-bug-reporter[bot] commented 5 months ago

Github username: @kodakr Twitter username: @Kodak_Rome Submission hash (on-chain): 0x583795c4d11c46f50c86555838ec16cca3bc363cff2e84a4a26a7cfb5270e867 Severity: high

Description: In eth\contracts\Migrations.sol::upgrade(), This implementation which is an exact copy of the current Migration.sol cannot be called by it. Hence cannot be setCompleted() Recall that the above named function is restricted to only the owner who is the msg.sender at deployment. Current Migration.sol is not the deployer hence lacks this access.

fbielejec commented 4 months ago

Does not follow submission guideline - no POC, but mostly marking as invalid as Migrations.sol should not be upgradeable at all. Migrations is just a counter, and using is an opt-in for migration scripts that can (but need not to) check whether a previous migration script was applied (context dependent).

fbielejec commented 4 months ago

duplicate with #3