hats-finance / Most--Aleph-Zero-Bridge-0xab7c1d45ae21e7133574746b2985c58e0ae2e61d

Aleph Zero bridge to Ethereum
Apache License 2.0
0 stars 1 forks source link

Recover function should be decentralised #72

Open hats-bug-reporter[bot] opened 4 months ago

hats-bug-reporter[bot] commented 4 months ago

Github username: -- Twitter username: 0xleadwizard Submission hash (on-chain): 0x584acb0846aacbf42876b496bd540e7b25649dd87f73f963516517d54d0d1a1b Severity: medium

Description: Description\ In the implementation of bridge contracts, the recoverNative and recoverERC20 functions act as single points of failure, allowing the owner to withdraw any user funds from the contract.

Given the current threats and incidents of attacks, it would be significantly safer if the owner could only withdraw funds designated as recoverable.

Attack Scenario\ The owner exploits the recoverNative or recoverERC20 function to misappropriate user funds.

Recommendation\ By using storage variables to monitor funds that encounter errors during the bridging process, this bridge can be made more trustworthy and less dependent on operator integrity.

image

krzysztofziobro commented 4 months ago

Invalid submission - issue assumes mistakes in governance actions or malicious committee