Description:Description\
In Minter.sol, an owner can call collectWithdrawalFees() to withdraw the fees. This function has used safeTransfer which transfers the fees to receiver address.
The issue here is that, collectWithdrawalFees() could allow reentrancy issue due to violation of Checks, Effects, Interaction pattern. where the effects are happening after transferring the tokens. It must be noted that, all external function calls must be performed at the end of functions and state should be updated before to it.
Recommendations\
Follow CEI pattern or add nonReentranct modifier on collectWithdrawalFees() to avoid reentrancy issues.
Github username: -- Twitter username: -- Submission hash (on-chain): 0x5529151e09b33810031083f111e067ffb0d1a1e92844738f22635f16497c35a2 Severity: low
Description: Description\ In
Minter.sol
, an owner can callcollectWithdrawalFees()
to withdraw the fees. This function has usedsafeTransfer
which transfers the fees to receiver address.The issue here is that,
collectWithdrawalFees()
could allow reentrancy issue due to violation of Checks, Effects, Interaction pattern. where the effects are happening after transferring the tokens. It must be noted that, all external function calls must be performed at the end of functions and state should be updated before to it.Recommendations\ Follow CEI pattern or add
nonReentranct
modifier oncollectWithdrawalFees()
to avoid reentrancy issues.