hats-finance / Palmera-0x5fee7541ddcd51ba9f4af606f87b2c42eea655be

Palmera hierarchical module
0 stars 1 forks source link

Lack of authority control #17

Open hats-bug-reporter[bot] opened 1 week ago

hats-bug-reporter[bot] commented 1 week ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0x87fb9b664d6e11ea8bc56c5e17a9335f45d2fc5b6b3f8a9faeb3459010d17e29 Severity: high

Description: Description

Anyone can call the setOwners function of the Attacker contract by changing its storage

Attack Scenario

Anyone can overwrite the variable owners

Attachments

function setOwners(address[] memory _owners) public {

it is advisable to use the onlyOwner modifier of the contract Ownable2Step.sol in this function

0xRizwan commented 1 week ago

Non-issue, ReentrancyAttack.sol is used only for simulation/testing.

alfredolopez80 commented 1 week ago

Non-issue, ReentrancyAttack.sol is used only for simulation/testing.

i agree @0xRizwan is invalid!!