No event emissions for critical state changes

[hats-bug-reporter[bot]]

Github username: -- Twitter username: -- Submission hash (on-chain): 0xe1d8117d162e44fe692ec6d1661742e92e4fc985abc458407bd0943728bbe773 Severity: low

Description: Description:

The following functions modify critical state variables, but no events are defined and emitted to broadcast the changes:

• PalmeraModule::enableAllowlist()
• PalmeraModule::enableDenylist()
• PalmeraModule::disableDenyHelper()
• Attacker::setOwners(address[])

Impact:

1. Reduced transparency
2. Difficulty to track changes
3. Inefficient or impossible integration with other contracts and services

Recommendation:

Define and emit events for critical changes performed in these functions

[0xRizwan]

This function is only for simulation/testing so emitting event is not required. For other functions, allowFeature and denyFeature are used as conditions in allowList and dropList functions, so not ensure they need event emission here.

[alfredolopez80]

totally agree @0xRizwan is not necessary