hats-finance / Palmera-0x5fee7541ddcd51ba9f4af606f87b2c42eea655be

Palmera hierarchical module
0 stars 4 forks source link

Event is missing `indexed` fields #64

Open hats-bug-reporter[bot] opened 3 months ago

hats-bug-reporter[bot] commented 3 months ago

Github username: @mhhacker111 Twitter username: -- Submission hash (on-chain): 0x2eb3255080389ce406e30f96af95197fac9e0e4c819c58e7f909148a50e7575d Severity: low

Description: Description\ Index event fields make the field more quickly accessible to off-chain tools that parse events. However, note that each index field costs extra gas during emission, so it's not necessarily best to index the maximum allowed per event (three fields). Each event should use three indexed fields if there are three or more fields, and gas usage is not particularly of concern for the events in question. If there are fewer than three fields, all of the fields should be indexed.

  1. Proof of Concept (PoC) File

    • Found in src/libraries/Events.sol Line: 13
        event OrganisationCreated(
0xRizwan commented 3 months ago

Informational at best, i don't think said events needs to be indexed and it does not seem to be intended.