Code Refactor - Gas Report

Github username: @mhhacker111 Twitter username: -- Submission hash (on-chain): 0x3c0a8755401cf1a326a3da16e49ed99c936ecb0eca3b015edd6d13a8b5e7b5d1 Severity: gas saving

Description: Description\ If orgHash is large, iterating through the entire array could be gas-intensive. Consider optimizing the data structure or caching results for frequently accessed safeId values.

Attachments

Original Code

/// @notice call to get the orgHash based on safe id
/// @dev Method to get the hashed orgHash based on safe id
/// @param safeId uint256 of the safe
/// @return orgSafe Hash (On-chain Organisation)
function getOrgBySafe(uint256 safeId)
    public
    view
    returns (bytes32 orgSafe)
{
    if ((safeId == 0) || (safeId > indexId)) revert Errors.InvalidSafeId();
    for (uint256 i; i < orgHash.length;) {
        if (safes[orgHash[i]][safeId].safe != address(0)) {
            orgSafe = orgHash[i];
        }
        unchecked {
            ++i;
        }
    }
    if (orgSafe == bytes32(0)) revert Errors.SafeIdNotRegistered(safeId);
}

Changed Code

function getOrgBySafe(uint256 safeId) public view returns (bytes32 orgSafe) {
    // Validate the safeId
    if ((safeId == 0) || (safeId > indexId)) revert Errors.InvalidSafeId();

    // Iterate over the orgHash array to find the matching safeId
    for (uint256 i = 0; i < orgHash.length;) {
        if (safes[orgHash[i]][safeId].safe != address(0)) {
            // Return the orgHash as soon as a match is found
            return orgHash[i];
        }
        unchecked {
            ++i;
        }
    }

    // Revert if no matching safeId is found
    revert Errors.SafeIdNotRegistered(safeId);
}

Files:

PalmeraModule.sol (https://hats-backend-prod.herokuapp.com/v1/files/QmfBz3EzqfwjSKXTnnj1s5C4RNLRBACoCfit73j8bzAENi)

hats-finance / Palmera-0x5fee7541ddcd51ba9f4af606f87b2c42eea655be

Code Refactor - Gas Report #67