hats-finance / Palmera-0x5fee7541ddcd51ba9f4af606f87b2c42eea655be

Palmera hierarchical module
0 stars 1 forks source link

Does not emit event after writing into storage #73

Open hats-bug-reporter[bot] opened 3 days ago

hats-bug-reporter[bot] commented 3 days ago

Github username: @mhhacker111 Twitter username: -- Submission hash (on-chain): 0xe238afae3d3e9f8bb72e9fd381509df60b59763e86dc6e4e98607a3f9efb9995 Severity: low

Description: L-1:Does not emit event after writing into storage

Following places in code doesn't emit evet after writing into storage.

4 Found Instances - Found in src/PalmeraModule.sol [Line: 290](src/PalmeraModule.sol#L290) ```solidity DataTypes.Safe storage _safe = safes[getOrgHashBySafe(caller)][safeId]; ``` - Found in src/PalmeraModule.sol [Line: 422](src/PalmeraModule.sol#L422) ```solidity DataTypes.Safe storage _safe = safes[org][safeId]; ``` - Found in src/PalmeraModule.sol [Line: 432](src/PalmeraModule.sol#L432) ```solidity DataTypes.Safe storage superSafe = safes[org][_safe.superSafe]; ``` - Found in src/PalmeraModule.sol [Line: 449](src/PalmeraModule.sol#L449) ```solidity DataTypes.Safe storage childrenSafe = safes[org][_safe.child[i]]; ```
0xRizwan commented 3 days ago

events are emitted, check here. For user role, check here