search

hats-finance / Proof-Of-Humanity-V2-0xef0709445d394a22704850c772a28a863bb780b0

Proof of Humanity Protocol v2
2 stars 1 forks source link

humanity cannot be request to be claimed for exact expiration timestamp. #64

Open hats-bug-reporter[bot] opened 2 months ago

hats-bug-reporter[bot] commented 2 months ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0x453c566474f97e382f012d8a78f540af622f4d206098d17d15a108f72a486503 Severity: high

Description: Description\ under ProofOfHUmanity.claimHumanity function a require condition checks for the expiration timestamp i.e; if the humanity expiration timestamp is lesser than block.timestmap it makes a claim request but it do not claim a request, when the expiration timestamp is exactly equals to block.timestmap,

require(humanity.owner == address(0x0) || humanity.expirationTime < block.timestamp);

If we see under ccDischargeHumanity function it deleted humanity for the expiration which is greater than blocktimestamp, it means humanity request can also be claimed for the exact expiration timestamp, which claimHumanity function do no take into consideration.

Recommendtion Add a equals to checks under the above require statement do that humaity request can also be made for exact block.timestmap.

clesaege commented 2 months ago

Correct, but already reported: https://github.com/hats-finance/Proof-Of-Humanity-V2-0xef0709445d394a22704850c772a28a863bb780b0/issues/29