hats-finance / Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
0 stars 1 forks source link

PUSH0 opcode Is Not Supported on Linea yet #20

Open hats-bug-reporter[bot] opened 1 week ago

hats-bug-reporter[bot] commented 1 week ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0x063b648261d87824f4b20ed1922bf1114e90f374ab40ed9eeff5d0f5032f6b28 Severity: medium

Description: Description

PUSH0 opcode Is Not Supported on Linea yet

Attack Scenario

Proof of Concept (PoC) File

Deploying the protocol on Linea with the current Solidity version (0.8.24 or > 0.8.20) may result in unexpected behavior or failure due to the unsupported PUSH0 opcode.

There are multiple reference which shows that contract will be deployed for 0.8.24 or >0.8.19

  1. https://github.com/hats-finance/Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac/blob/main/modules/passkey/hardhat.config.ts#L59

  2. https://github.com/hats-finance/Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac/blob/main/modules/passkey/README.md#compiler-settings

  3. https://github.com/hats-finance/Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac/blob/main/modules/passkey/contracts/libraries/P256.sol#L119

  4. Revised Code File (Optional)

for Linea you may consider to use version 0.8.19 to compile

0xEricTee commented 1 week ago

Duplicate of #19