search

hats-finance / Smooth-0x64bc275b37e62eec81a00ecaecd2b9567058f990

Dappnode's MEV Smoothing Pool
0 stars 2 forks source link

pragma solidity 0.8.21 uses PUSH0 which is not supported in L2's #12

Open hats-bug-reporter[bot] opened 1 year ago

hats-bug-reporter[bot] commented 1 year ago

Github username: @https://github.com/maarcweiss Submission hash (on-chain): 0x5977d80151c25b70d73ea26c293f6ce1acfeeba5628bced2cd3baf3c3e0f11f6 Severity: low

Description: Description\ DappnodeSmoothingPool has the version pragma fixed to be compiled using Solidity 0.8.21. https://github.com/dappnode/mev-sp-contracts/blob/3929e24ea288d697d38948b8690c8c2028e5042b/contracts/DappnodeSmoothingPool.sol#L2

This new version of the compiler uses the new PUSH0 opcode introduced in the Shanghai hard fork, which is now the default EVM version in the compiler and the one currently used to compile the project.

Recommendation\ Change the Solidity compiler version to 0.8.19 or define an evm version, which is compatible across all of the intended chains to be supported by the protocol (see https://book.getfoundry.sh/reference/config/solidity-compiler?highlight=evm_vers#evm_version).

invocamanman commented 1 year ago

This contract is meant to be deployed on ethereum mainnet.