search

hats-finance / Smooth-0x64bc275b37e62eec81a00ecaecd2b9567058f990

Dappnode's MEV Smoothing Pool
0 stars 2 forks source link

The collateral subscription of the validator is not returned in the function `unsubscribeValidator` #15

Open hats-bug-reporter[bot] opened 1 year ago

hats-bug-reporter[bot] commented 1 year ago

Github username: @Rotcivegaf Submission hash (on-chain): 0x67f6611ba684890ef60bbfd46848e65a2a6fcdf2b2180629584939969cb9a9ae Severity: high

Description:

Description

The subscriptionCollateral is payed in subscribeValidators and subscribeValidator functions but is not return when the validator is unsubscribe with unsubscribeValidator function

Impact

The collateral subscription of the validator is not returned

Recommendation

The value of subscriptionCollateral can be stored and returned in the unsubscribeValidator

Note: Since I can't talk to the protocol, I can't provide a complete solution

invocamanman commented 1 year ago

Duplicated: https://github.com/hats-finance/Smooth-0x64bc275b37e62eec81a00ecaecd2b9567058f990/issues/4