search

hats-finance / Thorn-protocol-0x1286ecdac50215a366458a14968fbca4bd95067d

GNU General Public License v3.0
0 stars 0 forks source link

`createSwapLP` and `createSwapPair` Do Not Handle Failed Contract Deployment Using `CREATE2` #27

Open hats-bug-reporter[bot] opened 1 month ago

hats-bug-reporter[bot] commented 1 month ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0xd65f86398f17c88bb2f6add723893e43349b8e7b58c5f67a0bc607b43fb97324 Severity: medium

Description: Description

In the StableSwapFactory contract, the createSwapLP and createSwapPair functions use the create2 opcode to deploy contracts. However, if the contract deployment fails, create2 will return the zero address (address(0)). Currently, there is no check to handle this failure, allowing the contract to proceed as if the deployment succeeded. This can lead to corrupting the factory’s internal state and state variables.

Attachments

  1. Revised Code

Add a check to handle failed contract deployments in the createSwapLP and createSwapPair functions. This will ensure that the contract reverts if the deployment fails, preventing the propagation of invalid states.

Robinx33 commented 1 month ago

it will return address(0) and this will revert StableSwapLP(lpToken).setMinter(_minter);.. There is no impact