`rebalanceSuccessfullyExecuted()` not validate input `params`.

[hats-bug-reporter[bot]]

Github username: @jraynaldi3 Twitter username: JuliusRaynaldi Submission hash (on-chain): 0x451906e374004efc3d816237dd6c74d84ec3038d4f5f9f55fb234399de4a7698 Severity: medium

Description: Description\ rebalanceSuccessfullyExecuted() , does not perform sufficient validation checks on its input variables. This lack of input validation introduces a high vulnerability, potentially exposing the contract to various security risks.

Unvalidated input including :

• address(0) check
• destinationIn == destinationOut
• ensure that destination is registered

Attachments

1. Proof of Concept (PoC) File

Missing input variable validation in this code line below line :

912    /// @inheritdoc ILMPStrategy
913    function rebalanceSuccessfullyExecuted(IStrategy.RebalanceParams memory params) external onlyLMPVault {
914        ...
939
940    }

code link

rebalanceSuccessfullyExecuted is a function that can alter the storage state it's recommended to give the input parameter a proper validation.

2. Revised Code File (Optional)

add validation for rebalanceSuccesfullyExecuted function by adding validateRebalanceParams(params) before anything else inside the function

912    /// @inheritdoc ILMPStrategy
913    function rebalanceSuccessfullyExecuted(IStrategy.RebalanceParams memory params) external onlyLMPVault {
++          validateRebalanceParams(params);
914        ...
939
940    }

[codenutt]

As per the documentation provided in the audit, the "Call Flow to the Strategy" section, the rebalanceSuccessfullyExecuted only occurs after verifyRebalance() is called. validateRebalanceParams is called there and will revert if necessary.