Open hats-bug-reporter[bot] opened 5 months ago
Github username: -- Twitter username: -- Submission hash (on-chain): 0x06dcae6f0d5d43ca9a8e07ce8e96f13927d7615128c34c91b2a4f6e197d963e0 Severity: low
Description: In provided documentation states that
But 2.1 is never checked
Here is code for updating NAV
function navUpdate(uint navPerShare) external onlyLMPVault { uint40 blockTime = uint40(block.timestamp); navTrackingState.insert(navPerShare, blockTime); clearExpiredPause(); if (navTrackingState.len > navLookback3InDays && !paused()) { uint nav1 = navTrackingState.getDaysAgo(navLookback1InDays); uint nav2 = navTrackingState.getDaysAgo(navLookback2InDays); uint nav3 = navTrackingState.getDaysAgo(navLookback3InDays); if (navPerShare < nav1 && navPerShare < nav2 && navPerShare < nav3) { lastPausedTimestamp = blockTime; } } }
And here when pause is reset
function clearExpiredPause() internal returns (bool) { if (!expiredPauseState()) return false; lastPausedTimestamp = 0; _swapCostOffsetPeriod = swapCostOffsetMinInDays; return true; }
As you can see there's no check for past NAV.
Impact: Bbehavior of the contracts differs from the intended behavior (as described in the docs).
Github username: -- Twitter username: -- Submission hash (on-chain): 0x06dcae6f0d5d43ca9a8e07ce8e96f13927d7615128c34c91b2a4f6e197d963e0 Severity: low
Description: In provided documentation states that
But 2.1 is never checked
Here is code for updating NAV
And here when pause is reset
As you can see there's no check for past NAV.
Impact: Bbehavior of the contracts differs from the intended behavior (as described in the docs).