search

hats-finance / VMEX-0x050183b53cf62bcd6c2a932632f8156953fd146f

LP token lending protocol
MIT License
2 stars 1 forks source link

Duplicate errors messages #53

Open hats-bug-reporter[bot] opened 1 year ago

hats-bug-reporter[bot] commented 1 year ago

Github username: @Rotcivegaf Submission hash (on-chain): 0xfdcd2ee440b94c80bd44794e4693bb7ee61a577ec8edddd4381099c4e39b9b10 Severity: low severity

Description:

Vulnerability Report

Description

Errors messages "105" and "106" are duplicated

File: packages/contracts/contracts/protocol/libraries/helpers/Errors.sol

134:    string public constant VO_WETH_SET_ONLY_ONCE = "105";

142:    string public constant LPAPR_ALREADY_SET = "105";
File: packages/contracts/contracts/protocol/libraries/helpers/Errors.sol

135:    string public constant VO_BAD_DENOMINATION = "106";

144:    string public constant LPC_TREASURY_ADDRESS_ZERO = "106"; //assetmappings does not allow setting collateral

Attack Scenario

Being duplicates could lead to confusion, the AAVE documentation does not have duplicate codes