search

hats-finance / Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77

Core smart contracts of Velvet Capital
Other
0 stars 1 forks source link

Unsafe ERC20 Operation #76

Open hats-bug-reporter[bot] opened 5 months ago

hats-bug-reporter[bot] commented 5 months ago

Github username: @krkbaa Twitter username: 0xkrkba Submission hash (on-chain): 0x91a240fc8b50e62a54052f6495341bbbede7a15b6898cabef6e5d877c2984806 Severity: low

Description: Description\ https://github.com/Velvet-Capital/velvet-core/blob/849629b1aacf32d84634d8c4ef1378527bce3bb3/contracts/bundle/DepositBatch.sol#L63

 IERC20(_token).approve(data._target, balance);

ERC20 functions may not behave as expected. For example: return values are not always meaningful. It is recommended to use OpenZeppelin's SafeERC20 library(safe approve).

Attack Scenario\

Attachments

  1. Proof of Concept (PoC) File

  2. Revised Code File (Optional)

langnavina97 commented 4 months ago

Thank you for this submission. While this is a good informational finding, it is not a security concern for our current implementation. Therefore, we consider this issue as invalid. @krkbaa