search

hats-finance / Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77

Core smart contracts of Velvet Capital
Other
0 stars 1 forks source link

` PriceOracle::oracleExpirationThreshold ` uses same ` oracleExpirationThreshold ` for all the pricefeed. #9

Open hats-bug-reporter[bot] opened 4 months ago

hats-bug-reporter[bot] commented 4 months ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0xdb1d03b9e1c9425e6fa34585398ac2572f3b0d2cddfac1e0788d1a366ed32a42 Severity: medium

Description: Description\

PriceOracle::oracleExpirationThreshold uses same oracleExpirationThreshold for all the pricefeed.

Same [PriceOracle::oracleExpirationThreshold](https://github.com/hats-finance/Velvet-Capital-0xe47e52c4fea05e555920f1dcdcc6fb8eca103eeb/blob/main/contracts/oracle/PriceOracleAbstract.sol#L57) is used for all the feeds which could give stale price

  1. Proof of Concept (PoC) File

Most of pricefeed have heartbeat of 1 hr and 24 hr, as seen from the constructor the oracleExpirationThreshold has been set to 25 hours, which is way more than heartbeat of most of the pricefeeds

There are different type of pricefeeds with large range(1 min to 24 hr) of heartbeats so checking stale price on the basis of oracleExpirationThreshold is completely wrong

if heartbeat is < 1 hr(eg ETH/USDC Also used in test files, has heartbeat is 60 seconds), chainlink updates price, iff price crosses deviation threshold or heartbeat time passed. As price movement can be slow in stable market condition so price will be updated only at heartbeats. So for ETH/USDC price could be stale after 60 seconds but the current implmentation doesn't check this. It could use stale price for 25 hours

https://github.com/hats-finance/Velvet-Capital-0xe47e52c4fea05e555920f1dcdcc6fb8eca103eeb/blob/main/contracts/oracle/PriceOracle.sol#L26

  1. Revised Code File (Optional)

Use specific oracleExpirationThreshold for every feed

langnavina97 commented 4 months ago

This issue is out of scope as it has already been addressed by the auditors. We decided not to make any changes since the price oracle is only being used for the performance fee.

Tri-pathi commented 4 months ago

@langnavina97

This issue is out of scope as it has already been addressed by the auditors

can you refer me to those reports where it is mentioned that this is known issue or already addressed. Since In this report can't see above issue addressed

Thankyou