hats-finance / Wise-Lending-0xa2ca45d6e249641e595d50d1d9c69c9e3cd22573

0 stars 1 forks source link

# GHOST supply shares steal interest #33

Open hats-bug-reporter[bot] opened 8 months ago

hats-bug-reporter[bot] commented 8 months ago

Github username: @g01u Twitter username: g01uu Submission hash (on-chain): 0x7e2ff1aa3147a4e7c3db10d074d3c4af0d563ebc96dea11c5ec45f2336465ab3 Severity: high

Description: Description

The GHOST supply shares, that are not owned by anyone, earn interest in _accrueInterest. This interest is stolen from the actual suppliers which leads to loss of interest funds for users. Note that while the ghost share price of 1e-6 might make it seem like the GHOST Shares can be ignored, one can increase the supply share price, and the GHOST Shares will have a bigger claim on the total asset percentage.

Impact

Likelihood High: The GHOST supply shares exist in every single market, and this issue exists in every single market.

Recommendation

The GHOST shares should not earn interest as they don't correspond to any supplier.

vm06007 commented 8 months ago

@g01u please refer to reply that's been added here: https://github.com/hats-finance/Wise-Lending-0xa2ca45d6e249641e595d50d1d9c69c9e3cd22573/issues/34