Open hats-bug-reporter[bot] opened 11 months ago
Github username: -- Submission hash (on-chain): 0x1e594f92fde0c1e75fa6282565f3fbe46d7ec1988b7a969ea38a8d9be1a913c3 Severity: low
Description: Attack Scenario
IncreaseAllowance and decreaseAllowance methods have been removed form @OpenZeppelin's implementation of ERC20.
https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4585
These functions are not part of the EIP-20 specs.
Attachments
Use safeIncreaseAllowance & safeDecreaseAllowance, it uses forceApproval. It's better to use non-depreciated standards to not affect future development.
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/60e3ffe6a3cc38ab94cae995bc1de081eed79335/contracts/token/ERC20/utils/SafeERC20.sol#L48-L69
Github username: -- Submission hash (on-chain): 0x1e594f92fde0c1e75fa6282565f3fbe46d7ec1988b7a969ea38a8d9be1a913c3 Severity: low
Description: Attack Scenario
IncreaseAllowance and decreaseAllowance methods have been removed form @OpenZeppelin's implementation of ERC20.
https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4585
These functions are not part of the EIP-20 specs.
Attachments
Use safeIncreaseAllowance & safeDecreaseAllowance, it uses forceApproval. It's better to use non-depreciated standards to not affect future development.
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/60e3ffe6a3cc38ab94cae995bc1de081eed79335/contracts/token/ERC20/utils/SafeERC20.sol#L48-L69