Missing storage gap for upgradeable contracts

[hats-bug-reporter[bot]]

Github username: @Rotcivegaf Submission hash (on-chain): 0xbb9d31c12283be8881f204f12e6299ba2463e67b6a452ddb23d605d9e41e528c Severity: low

Description:

Description

Storage gaps are a convention for reserving storage slots in a base contract, allowing future versions of that contract to use up those slots without affecting the storage layout of child contracts. storage-gaps recommendation

This list of contracts are an Upgradeable buy don't have gap:

• AuctionManager
• BNFT
• EETH
• EtherFiAdmin
• EtherFiNodesManager
• EtherFiOracle
• LiquidityPool
• MembershipManager
• MembershipManagerV0
• MembershipNFT
• NFTExchange
• NodeOperatorManager
• ProtocolRevenueManager
• RegulationsManager
• StakingManager
• TNFT
• WeETH
• WithdrawRequestNFT

Recommendation

Add an appropriate storage gap at the end of contracts:

uint256[50] private __gap;

[seongyun-ko]

This is unnecessary if we do not consider inheritance. we don't

[rotcivegaf]

Agree, sorry, in the rush I couldn't make sure if it was really a bug You can close this