Separate vault and claims manager

[ben-kaufman]

Summary by CodeRabbit

• New Feature: Introduced HATKlerosV2Connector contract to bridge HatsFinance and Kleros court V2, enabling dispute resolution.
• Refactor: Separated vault and claims manager functionality in HATGovernanceArbitrator.sol, HATTimelockController.sol, and HATVaultsRegistry.sol for improved flexibility and management.
• New Feature: Added ability to challenge claims, notify the arbitrator, give a ruling for a dispute, and get the arbitration cost via the new HATKlerosV2Connector contract.
• Refactor: Updated HATVaultsRegistry contract with a new variable hatClaimsManagerImplementation for better control over vault implementations.

[github-actions[bot]]

CodeRabbit

Walkthrough

This update separates the vault and claims manager functionality in the HATFinance contracts, introducing more flexibility. It also adds a new contract, HATKlerosV2Connector, to bridge HatsFinance and Kleros court V2, enabling dispute management and arbitration cost calculation.

Changes

File(s)	Summary
contracts/HATGovernanceArbitrator.sol, contracts/HATTimelockController.sol, contracts/HATVaultsRegistry.sol	The diff modifies these contracts to separate the vault and claims manager functionalities. It changes the _vault parameter type in approveClaim and dismissClaim functions from HATVault to IHATClaimsManager. A new variable hatClaimsManagerImplementation is added to HATVaultsRegistry contract, and its constructor and setVaultImplementations function are updated accordingly.
contracts/HATKlerosV2Connector.sol	This new contract acts as a connector between HatsFinance and Kleros court V2. It includes functions for challenging claims, notifying the arbitrator, giving a ruling for a dispute, and getting the arbitration cost. It stores disputes, tracks challenged claims, and maps external dispute IDs to local dispute IDs.

🐰 "In the land of code, where logic intertwines,

Changes come forth, like sun that brightly shines.

Separation of concerns, a principle we adore,

Now vaults and claims, are together no more.

And a new bridge is built, with Kleros it aligns,

For disputes and costs, it cleverly defines.

So let's hop and cheer, for this update so fine,

In the world of contracts, it's a golden sign!" 🎉

---

Uplevel your code reviews with CodeRabbit Pro

### CodeRabbit Pro If you like this project, please support us by purchasing the [Pro version](https://coderabbit.ai). The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

[openzeppelin-code[bot]]

Separate vault and claims manager

Generated at commit: d79402b1a7157ab616f7d7a0f20c1a511b51303d

🚨 Vulnerabilities Summary

Process	Issues	Results
Contract Inspector	note low critical Total	21 9 1 31
Dependency Checker	Total	0

---

For more details view the full report in OpenZeppelin Code

[jellegerbrandy]

Closing this PR as it is messed up