search

hats-finance / hats-contracts

MIT License
37 stars 47 forks source link

Hackers nft updates #510

Closed ben-kaufman closed 1 year ago

ben-kaufman commented 1 year ago

Removes vault, description, and tier from the NFT and use the IPFS hash for the token ID. Adds option to permanently stop minting of an NFT or multiple NFTs. Adds HATHackersNFT to the deployement scripts and deploy to Goerli. Transfer ownership to Hats governance on deployment.

ben-kaufman commented 1 year ago

Hi, so I'm not sure about the comments.

  1. I could add a createAndMint function or something, but I don't think it's in any way unnatural to have the create separated from the minting. The create only happens one, while minting can be called many times. So I think it makes sense to separate them.
  2. To use that "whitelist" to stop minting would mean to delete/ alter the uri of the NFT which is not what we want. And the blacklisting to not be able to ever mint (even though it's only owner) was a requirement Shay asked for.