hats-finance / hats-contracts

MIT License
37 stars 47 forks source link

Separate vaults and Claims manager #530

Closed jellegerbrandy closed 1 year ago

jellegerbrandy commented 1 year ago

Summary:

github-actions[bot] commented 1 year ago

Image description CodeRabbit

Walkthrough

This update primarily refactors the contracts to replace IHATVault interface with IHATClaimsManager. It modifies function signatures and mappings in several contracts, introduces a new variable in HATVaultsRegistry, and updates event parameters. These changes may affect the external behavior of the code.

Changes

Files Summary
HATArbitrator.sol, HATGovernanceArbitrator.sol, HATKlerosConnector.sol, HATKlerosV2Connector.sol The IHATVault interface has been replaced with IHATClaimsManager in these contracts. Function signatures and mappings have been updated accordingly.
HATTimelockController.sol Function signatures have been modified to accept additional parameters of various types.
HATVaultsRegistry.sol A new variable hatClaimsManagerImplementation has been added. The constructor and setVaultImplementations function have been updated to handle this variable. The createVault function and VaultCreated event have also been updated with new parameters.

"In the land of code, where logic is king, 🤴 A rabbit hopped by, changing everything. 🐇💻 With a twitch of his nose, and a flick of his ear, 👃👂 He replaced IHATVault, with no hint of fear. 💪 Now IHATClaimsManager reigns supreme, 👑 Making our contracts work like a dream. 💭✨"


Uplevel your code reviews with CodeRabbit Pro ### CodeRabbit Pro If you like this project, please support us by purchasing the [Pro version](https://coderabbit.ai). The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.