hats-finance / illuminex-0x0bb4aa1f58719707405c231fcdf0b405714799cf

0 stars 1 forks source link

Missing event emission in `packages/contracts/contracts/illuminex/xengine/chains/btc/wallet/VaultBitcoinWallet.sol::withdraw`. #27

Open hats-bug-reporter[bot] opened 3 months ago

hats-bug-reporter[bot] commented 3 months ago

Github username: @erictee2802 Twitter username: 0xEricTee Submission hash (on-chain): 0x39a0e25ef132c15bcecb0addf0f7aa86cb640228c8a99e4949dd1d334351d2d8 Severity: low

Description: Description

The function packages/contracts/contracts/illuminex/xengine/chains/btc/wallet/VaultBitcoinWallet.sol::withdraw is missing event emission. Emitting events when these actions occur is essential for transparency and informing users about important changes. Adding events for these functions will provide users with a clear record of when withdrawals have been requested.

Attack Scenario

The absence of events for these critical functions may result in a lack of transparency, making it difficult for users to track important changes in the contract. Emitting events can ensures that users are informed.

Attachments

NA

  1. Proof of Concept (PoC) File

Manual analysis

  1. Revised Code File (Optional)

    Consider adding event emission in packages/contracts/contracts/illuminex/xengine/chains/btc/wallet/VaultBitcoinWallet.sol::withdraw.

rotcivegaf commented 3 months ago

Informational

0xEricTee commented 3 months ago

@rotcivegaf

Similar issues were awarded as Low in Hats.Finance contests before.

rotcivegaf commented 3 months ago

As I said in the hats discord and you affirmed https://discord.com/channels/810534320040837121/1250435910080925707/1258607595531276329 this issue is informational

Like the Hats.Finance contests before, the protocol haves the last word