hats-finance / illuminex-0x0bb4aa1f58719707405c231fcdf0b405714799cf

0 stars 1 forks source link

Unbounded fee #3

Open hats-bug-reporter[bot] opened 4 months ago

hats-bug-reporter[bot] commented 4 months ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0x7baf24a0cebcf0d5ca1b040bf9acfb1704ec36671a023d3039cd93e474ee66a9 Severity: medium

Description: Description\ The VaultBitcoinWallet - setFee() function allows any number in uint64 to be set as a _satoshiPerByte. This can lead to several problems:

Recommendation\ Consider to mitigate this issue by setting a reasonable maximum upper cap for the fee (e.g. 20%)

rotcivegaf commented 4 months ago

It's not a medium issue The feeSetter it's set by the owner so it's trusted I think it's informational issue