Open hats-bug-reporter[bot] opened 3 months ago
Github username: @Jelev123 Twitter username: zhulien_zhelev Submission hash (on-chain): 0x82df056c7aea1e6fa2e32a3f550ddd53bf445756278ab3cbe750cc347e228e5d Severity: low
Description: Description\ In BitcoinProver.sol setMinConfirmations function set minConfirmations, but it doesnt check for max minConfirmations
BitcoinProver.sol
setMinConfirmations
minConfirmations
function setMinConfirmations(uint8 _newConfirmations) public onlyOwner { emit MinConfirmationsUpdate(_newConfirmations, minConfirmations); minConfirmations = _newConfirmations; }
Recommendation
check _newConfirmations <= minConfirmations before set the new minConfirmations
_newConfirmations <= minConfirmations
Github username: @Jelev123 Twitter username: zhulien_zhelev Submission hash (on-chain): 0x82df056c7aea1e6fa2e32a3f550ddd53bf445756278ab3cbe750cc347e228e5d Severity: low
Description: Description\ In
BitcoinProver.sol
setMinConfirmations
function setminConfirmations
, but it doesnt check for maxminConfirmations
Recommendation
check
_newConfirmations <= minConfirmations
before set the newminConfirmations