hats-finance / illuminex-0x0bb4aa1f58719707405c231fcdf0b405714799cf

0 stars 1 forks source link

Missing check for `minConfirmations` #34

Open hats-bug-reporter[bot] opened 3 months ago

hats-bug-reporter[bot] commented 3 months ago

Github username: @Jelev123 Twitter username: zhulien_zhelev Submission hash (on-chain): 0x82df056c7aea1e6fa2e32a3f550ddd53bf445756278ab3cbe750cc347e228e5d Severity: low

Description: Description\ In BitcoinProver.sol setMinConfirmations function set minConfirmations, but it doesnt check for max minConfirmations

  1. Proof of Concept (PoC) File
    function setMinConfirmations(uint8 _newConfirmations) public onlyOwner {
        emit MinConfirmationsUpdate(_newConfirmations, minConfirmations);
        minConfirmations = _newConfirmations;
    }

    Recommendation

check _newConfirmations <= minConfirmations before set the new minConfirmations