Illuminex across its contracts have used require() error handling. At some places, short string message e.g "NEV", "AHS", etc has been used. This short form is lower the string message length which is a gas saving measure.
The issue is that, at most of the function, require() revert string message is missing.
For example:
1) In RefuelTxSerializer.sol, constructor has used require() error handling but missed revert string message.
2) In OutgoingQueue.sol, init(), push() and popBufferedTransfersToBatch() functions have missing require revert string message.
and SO on . . .
Recommendation to fix\
Consider adding revert string message in require() error handling, otherwise for above mentioned instances, it would be difficult to understand the function revert.
rotcivegaf
commented
4 months ago
Github username: -- Twitter username: -- Submission hash (on-chain): 0x949209eccf528ab23dc67ae69226b1dbac509b37d8251014d81879c0a184a89e Severity: low
Description: Description\
Illuminex across its contracts have used
require()error handling. At some places, short string message e.g "NEV", "AHS", etc has been used. This short form is lower the string message length which is a gas saving measure.The issue is that, at most of the function,
require()revert string message is missing.For example:
1) In
RefuelTxSerializer.sol, constructor has usedrequire()error handling but missedrevert string message.2) In
OutgoingQueue.sol,init(),push()andpopBufferedTransfersToBatch()functions have missing require revert string message.and SO on . . .
Recommendation to fix\
Consider adding revert string message in
require()error handling, otherwise for above mentioned instances, it would be difficult to understand the function revert.