hats-finance / illuminex-0x0bb4aa1f58719707405c231fcdf0b405714799cf

0 stars 1 forks source link

scripts : vault : illuminex_btc_vault.wallet-template.json - vault is not supporting the latest VM #66

Open hats-bug-reporter[bot] opened 2 weeks ago

hats-bug-reporter[bot] commented 2 weeks ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0x00bd1829c5f6d5705fb628b365ce4454ed4b3abda5605fd802bf7890c3e6d551 Severity: low

Description: Description\

In the vault, the illuminex_btc_vault.wallet-template.json defines the list of suported VM versions as shown below.

/illuminex_btc_vault.wallet-template.json#L45-L49

  "supported": [
    "BCH_2020_05",
    "BCH_2021_05",
    "BCH_2022_05"
  ],

It has the list of authentication virtual machine versions supported by this template. Virtual machine identifiers use the format CODE_YYYY_MM, where CODE is the currency code used to identify the network, and YYYY_MM is the year and month in which the specified VM version became active on the indicated network. Identifiers with the _SPEC suffix indicate that this template is intended for compatibility with a future virtual machine version, but at the time the template was created, that virtual machine had not yet become active on the specified chain.

When we checked, the latest VM update is BCH2023 which has the some of the updated opcodes.

to know more about these update refer the blow link.

https://github.com/bitauth/libauth/blob/ade015123b2bfdbca721602cda19191c6f12252d/src/lib/vm/instruction-sets/bch/2023/bch-2023-descriptions.ts#L205-L210

OP_UTXOTOKENCATEGORY = 0xce, OP_UTXOTOKENCOMMITMENT = 0xcf, OP_UTXOTOKENAMOUNT = 0xd0, OP_OUTPUTTOKENCATEGORY = 0xd1, OP_OUTPUTTOKENCOMMITMENT = 0xd2, OP_OUTPUTTOKENAMOUNT = 0xd3,

Impact\ Vault could not be able to support the latest udpated features.

  1. Revised Code File (Optional)

Include the latest BCH version in the vault support.

party-for-illuminati commented 2 weeks ago

Not an issue, we do not use new BTC opcodes