Does not emit event after writing into cricial storage slots

[hats-bug-reporter[bot]]

Github username: -- Twitter username: -- Submission hash (on-chain): 0xb6907b0e73174aed29e99e9409893885c2d2d4ed3204fdb67e4c0ba603d2f0b5 Severity: low

Description: Description

BitcoinProver doesn't emit events after updating the keypair via updateContractKeys() and during the setting of minimum witness confirmations through setMinConfirmations().

Event emissions offer transparency and on-chain information about state changes of state variables

    function updateContractKeys() public onlyOwner {
        _updateKeyPair();
    }

    function setMinWitnessConfirmations(uint8 _min) public onlyOwner {
        _setMinWitnessSignatures(_min);
    }

However, the protocol strictly emits events after writing into other storage slots, which is missing in these functions.

Emit proper event after changing keypair and min witness signatures

[rotcivegaf]

Informational

[Tri-pathi]

@rotcivegaf

Quoting from Hat docs

Low Severity: These are typically minor issues that pose a limited impact on the system. They might include: Inefficiencies in gas usage. Minor deviations from best practices that don't lead to security risks. Small bugs that do not affect the protocol's functionality or security

Such issues have always been accepted in every public contest platform as Low (even in Hats)

This issue would have been informational if the contract didn't emit an event at any state variable update. Since it does emit events for all other storage variables, this was clearly missed.