Closed eembees closed 3 years ago
Currently we have this loading structure: https://github.com/hatzakislab/DeepFRET-GUI/blob/1358a5e2aa4ccbb68e98508daba6e15d8b0d0973/src/main/python/lib/container.py#L206-L220
And the way we check if a trace is exported from iSMS / is ALEX goes like this:
https://github.com/hatzakislab/DeepFRET-GUI/blob/1358a5e2aa4ccbb68e98508daba6e15d8b0d0973/src/main/python/lib/container.py#L264-L290
This is NOT robust to changes in datatypes etc. and risks that core functionality is compromised.
I think it's high time that this is changed to be more transparent:
load_trace
.dat
pd.DataFrame.from_csv
To avoid messing with build settings this should also avoid introducing any new dependencies or other finicky things.
Currently we have this loading structure: https://github.com/hatzakislab/DeepFRET-GUI/blob/1358a5e2aa4ccbb68e98508daba6e15d8b0d0973/src/main/python/lib/container.py#L206-L220
And the way we check if a trace is exported from iSMS / is ALEX goes like this:
https://github.com/hatzakislab/DeepFRET-GUI/blob/1358a5e2aa4ccbb68e98508daba6e15d8b0d0973/src/main/python/lib/container.py#L264-L290
This is NOT robust to changes in datatypes etc. and risks that core functionality is compromised.
I think it's high time that this is changed to be more transparent:
load_trace.datfiles, ALEX/non-ALEX )pd.DataFrame.from_csvof the trace, and detect the different type based on the CSV headers.To avoid messing with build settings this should also avoid introducing any new dependencies or other finicky things.