haubna / PhysicsMod

Physics Mod for Minecraft
97 stars 10 forks source link

Inconsistent lighting on physics objects with Blue's Dynamic Lights mod for Forge #540

Closed Oranamous closed 1 year ago

Oranamous commented 1 year ago

Describe the bug Light casted by held items with BDL (Blue's Dynamic Lights) doesn't get applied due to BDL's usage of core shaders to apply the custom light, and Physics Mod's usage of custom core shaders in the jar for physics objects. I was unable to patch Physics Mod's shaders using a resource pack, and I'm not sure if that would've helped anyway due to BDL's usage of custom uniforms. After further investigation I found that Physics Mod only accepts shader resources from inside it's own jar. I would prefer not to have to edit the Physics Mod's shaders directly in the jar each time I update the mod, I'm not experienced enough or sure if it's even possible to create a separate mod that patches Physics Mod to have compatibility with BDL. 🤔

To Reproduce Install both Physics Mod and Blue's Dynamic Lights on forge and open the game. Go to a dark area and place some blocks, hold a torch or glowstone and destroy the blocks you placed to get some physics objects to appear. Observe the dark lighting on the physics objects, while the surrounding area is lit by the held item.

Screenshots Normal behavior with block lights: 2023-01-18_22 04 48 Inconsistent behavior with held lights: 2023-01-18_22 05 01

Minecraft Version: Tested on 1.19.2 and 1.19.3, likely applies to all versions where both mods are present Physics Mod Version: 2.9.4, issue still present in 2.9.7

haubna commented 1 year ago

This will likely never be supported since shaders already do this without destroying my lighting improvements.

Oranamous commented 1 year ago

Understandable, I figured I'd report it just in case. Would it be possible for me to fix this myself, and would you be alright with me editing a local copy of the mod in order to do so? I won't attempt to crack a copy of the pro version, I just want to fix this compatibility issue as it breaks my immersion.

haubna commented 1 year ago

Oh yeah for sure, go ahead!

haubna commented 1 year ago

Fixed in V112 (will come to lite version soon too)

Oranamous commented 1 year ago

Issue still occurs after checking that both mods are up-to-date, despite curseforge changelogs stating that this is fixed 🤔

image

Oranamous commented 1 year ago

It appears this is fixed for some users but not others. A friend of mine showed it working, but for me it doesn't, and we were both using the same modpack and the same settings. My guess is it's a GPU-specific problem.