haubna / PhysicsMod

Physics Mod for Minecraft
103 stars 10 forks source link

Bug description [BUG] #978

Open Zortabre opened 2 months ago

Zortabre commented 2 months ago

Describe the bug Physics mod uses incorrect water colors with ocean physics(unsure what is conflicting with this)

To Reproduce Turning ocean physics on makes the color of certain bodies of water (mostly rivers and underground water) render in the wrong color. Only affects water source blocks.

Screenshots image With Ocean physics turned on, LOD from Distant Horizons uses different (correct) color for the water while physics mod makes it appear greenish brown

image Ocean physics turned off

Minecraft Version: <1.21> Physics Mod Version:

Zortabre commented 2 months ago

A simple fix for this would be to release a resource pack that replaces the water color to match the ocean physics colors for consistency.

haubna commented 2 months ago

Ocean physics colors the water based on the biome (like vanilla minecraft does). My guess is that the LODs of distant horizons ignore that color and simply take the default water color. So this should be fixed on the distant horizons side.

Zortabre commented 2 months ago

Ocean physics colors the water based on the biome (like vanilla minecraft does). My guess is that the LODs of distant horizons ignore that color and simply take the default water color. So this should be fixed on the distant horizons side.

This response fails to account for the second screenshot, in which ocean physics is turned off and the water color matches the DH water.

Here is another example, with Ocean Physics turned on, the water source blocks in caves have a different color than the flowing water.

With Ocean Physics on: image

With Ocean Physics off: image

Zortabre commented 2 months ago

Here's an example with dripstones showing the true color of the biome water, contrasted with Ocean Physics' water

With Ocean Physics on: image

With Ocean Physics off: image

haubna commented 2 months ago

Do you use any kind of other mod that alters biomes? From my testing with only the physics mod installed the biome colors seem to be correct.

Physics Mod on: 2024-09-18_09 47 16

Physics Mod off: 2024-09-18_09 50 11

Zortabre commented 2 months ago

I only use William Wyther's Overhauled Overworld, and Lithosphere

Zortabre commented 1 month ago

Any updates with this? It would be nice to at least have a resource pack that would make water stay consistent with the ocean physics.