search

haubourg / EasyCustomLabeling

plugin QGIS d'étiquetage manuel simplifié
9 stars 3 forks source link

rotated maps #8

Open antoniusz opened 8 years ago

antoniusz commented 8 years ago

Hi, The line/s, connecting the labels, doesn't conform to the rotation of the canvas or of the map in the composer.

See attachment.

rotated_map_with_labels

haubourg commented 8 years ago

Hi, thanks for raising this. Current code uses map coordinates to compute labels. Handling this would require additional signal/slots to recompute them on the fly with every rotation modification. What is your need? Do you assume that labels should stick to their map coordinates when rotating, or do you assume that labels should keep flat ends on screen, which need to reposition labels on the fly? I probably wont fix the plugin (but anyone can submit pull request, I will happily merge them), but I will raise that in https://github.com/qgis/QGIS-Enhancement-Proposals/issues/47 where we are currently discussing native labeling improvements. Régis

antoniusz commented 8 years ago

Hi, My problem is the connector line. It doesn't rotate with the label. On the sample, the doted line - grid - originally (on map canvas) was vertical. As you can see the indicated line (shorter part of the connector line) was made with unrotated map canvas, but after rotation in composer remained so. I've tried to rotate the map canvas, but then i hadn't been able to move the labels.

haubourg commented 8 years ago

Right, so you need labels connectors to be recomputed on when map rotates. Adding this in QEP 47 as a requirement. Refactoring Easylabeling is a big task and I have no free time by now. I prefer funding core features. If anyone has some time to connect canvas rotation events to the connector computing part, feel free!

haubourg commented 8 years ago

Hum, two other points: