search

haugene / vpn-configs-contrib

A collection of configs for various VPN providers
GNU General Public License v3.0
180 stars 744 forks source link

Add all ProtonVPN country configs #117

Closed Forage closed 2 years ago

Forage commented 2 years ago

This change uses the original configs as-is except:

Fixes #116

Breaking change

Proposed change

Add all ProtonVPN country configs, missed in #113

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

haasanen commented 2 years ago

@Forage These files are broken. The problem: the files in this PR reference old protonvpn.com domains. E.g. nl.protonvpn.com for Netherlands, but if you do a DNS query, there is no IP associated to it. This throws the following problem in Transmission: RESOLVE: Cannot resolve host address: nl.protonvpn.com:1194 (No address associated with hostname)

The new configuration files for each country should have a long list of IP addresses, instead of a domain name. At least they do on the files that I've downloaded from ProtonVPN.

Also, as related to my comment on the other PR (#113), this PR also includes configs that aren't meant for P2P.

Only the following countries should be included:

I understand that this was also done with the same "Download all configurations" and just submitted.

In the same way as there was a second CA certificate for the node config files, there is also a second certificate for the country config files. I'm not sure why the file you have submitted don't include the second certificate. See also the comment in the other PR: #113.

I did also notice that when downloading each file separately for a country, you get protonvpn.net instead of protonvpn.com. You only get the old name .com when downloading all country configs in a bundle. Not sure what is going on with this inconsistency.

Forage commented 2 years ago

If there is an issue with a config than the Proton VPN site provides invalid configs.

haasanen commented 2 years ago

If there is an issue with a config than the Proton VPN site provides invalid configs.

This is odd as the configuration files that I get from ProtonVPN don't match the ones in this PR. The country specific config files that I get from ProtonVPN contain a long list of IP addresses and not *.protonvpn.com addresses. Have you checked whether the files you have uploaded are out of date or are you still being provided config files that contain *.protonvpn.com addresses?

For example, the file nl.protonvpn.com.udp.ovpn in this PR has the following lines (36-40):

remote nl.protonvpn.com 80
remote nl.protonvpn.com 5060
remote nl.protonvpn.com 1194
remote nl.protonvpn.com 4569
remote nl.protonvpn.com 51820

If I select a "Download all configurations", then the nl.protonvpn.com.udp.ovpn file has the following lines (36-99):

remote 185.107.57.50 80
remote 46.166.182.100 5060
remote 192.40.57.55 51820
remote 192.40.57.55 80
remote 190.2.132.139 51820
remote 85.159.237.72 1194
remote 107.181.180.172 80
remote 190.2.132.124 1194
remote 185.107.57.1 5060
remote 185.107.57.50 5060
remote 62.112.9.164 80
remote 192.40.57.50 80
remote 107.181.180.172 5060
remote 190.2.146.180 4569
remote 185.107.57.1 1194
remote 62.112.9.164 5060
remote 190.2.132.139 80
remote 185.107.80.190 80
remote 192.40.57.236 1194
remote 190.2.131.156 4569
remote 192.40.57.236 80
remote 192.40.57.236 5060
remote 190.2.132.139 1194
remote 185.107.80.190 4569
remote 190.2.131.156 5060
remote 138.199.7.129 5060
remote 62.112.9.164 4569
remote 192.40.57.50 5060
remote 77.247.178.180 51820
remote 185.107.57.49 1194
remote 192.40.57.55 4569
remote 185.107.80.190 51820
remote 146.70.86.114 5060
remote 190.2.132.124 4569
remote 185.107.57.1 4569
remote 185.107.57.49 51820
remote 185.107.57.1 51820
remote 190.2.132.124 5060
remote 190.2.146.180 1194
remote 85.159.237.72 4569
remote 138.199.7.129 51820
remote 46.166.182.100 51820
remote 192.40.57.236 4569
remote 146.70.86.114 80
remote 77.247.178.180 80
remote 190.2.132.139 4569
remote 107.181.180.172 1194
remote 185.107.95.209 1194
remote 185.107.80.190 1194
remote 138.199.7.129 1194
remote 190.2.146.180 5060
remote 185.107.57.49 80
remote 146.70.86.114 1194
remote 85.159.237.72 80
remote 46.166.182.100 80
remote 192.40.57.55 1194
remote 192.40.57.50 4569
remote 77.247.178.180 1194
remote 190.2.132.139 5060
remote 146.70.86.114 51820
remote 185.107.95.209 5060
remote 185.107.57.50 4569
remote 190.2.132.124 51820
remote 46.166.182.100 4569

If I download the Netherlands file alone, then the nl.protonvpn.net.udp.ovpn file has the following lines (36-95): 

remote 190.2.132.139 5060
remote 192.40.57.55 1194
remote 185.107.95.209 80
remote 190.2.132.124 80
remote 138.199.7.129 51820
remote 85.159.237.72 1194
remote 192.40.57.50 1194
remote 138.199.7.129 80
remote 192.40.57.50 5060
remote 85.159.237.72 80
remote 185.107.80.190 80
remote 85.159.237.72 51820
remote 190.2.132.124 51820
remote 138.199.7.129 4569
remote 192.40.57.50 51820
remote 46.166.182.100 5060
remote 190.2.146.180 4569
remote 185.107.57.50 5060
remote 185.107.95.209 51820
remote 138.199.7.129 1194
remote 190.2.146.180 5060
remote 185.107.80.190 5060
remote 107.181.180.172 51820
remote 190.2.132.139 4569
remote 192.40.57.50 80
remote 192.40.57.55 51820
remote 46.166.182.100 51820
remote 185.107.80.190 1194
remote 107.181.180.172 1194
remote 185.107.57.50 1194
remote 190.2.132.139 80
remote 107.181.180.172 80
remote 85.159.237.72 5060
remote 185.107.57.50 51820
remote 190.2.132.139 51820
remote 185.107.57.50 4569
remote 192.40.57.55 5060
remote 46.166.182.100 1194
remote 185.107.57.50 80
remote 190.2.146.180 1194
remote 192.40.57.55 4569
remote 185.107.95.209 4569
remote 185.107.95.209 5060
remote 190.2.132.139 1194
remote 190.2.146.180 80
remote 190.2.132.124 1194
remote 107.181.180.172 4569
remote 107.181.180.172 5060
remote 185.107.95.209 1194
remote 190.2.146.180 51820
remote 192.40.57.55 80
remote 185.107.80.190 4569
remote 190.2.132.124 5060
remote 190.2.132.124 4569
remote 85.159.237.72 4569
remote 192.40.57.50 4569
remote 138.199.7.129 5060
remote 46.166.182.100 4569
remote 46.166.182.100 80
remote 185.107.80.190 51820

The old configuration files from ProtonVPN used to contain *.protonvpn.com lines, but I don't know when they have changed this. The country subdomains under protonvpn.com don't have DNS addresses anymore.

Forage commented 2 years ago

Than they must have changed/fixed it recently after the PRs. I only downloaded the lot once, so no old configs were present. It does not surprise me that they fixed it recently either since I got server deprecated e-mails for some connections even after having replaced the configs with the most recent ones. I'll update them again to see if there are changes and create a new PR if so.

haasanen commented 2 years ago

Thank you!

I've been getting those emails as well. The problem with the country specific files only came to my attention yesterday when my server downloaded a refreshed list from this repo. Proton has also gone through some rebranding where they merged their "Basic and Plus" VPN services into "Standard", or something like that. I'd assume their inconsistencies with the configuration files may have something to do with this transition period.

Would you mind also checking the CA field too? I get two certificates in the config files when I download a fresh copy from ProtonVPN website. This may have also changed recently.

Forage commented 2 years ago

Indeed, the "download all" config options give me a butt-load of changes to the profiles again. Your NL config is corrected now as well. Fixed in #120.

haasanen commented 2 years ago

I figured out the change in the CA certificates.

It seems that the one you downloaded was Router version of the configs. The Router version comes with the extra up and down lines, which you commented out. The other configs don't have these two lines. The Android config has two CA certificates, but the others don't. I haven't checked, but my guess is that the Android version is probably just a CA chain.

Forage commented 2 years ago

As the configs are used by Ubuntu in Docker I'm downloading the Linux configs each time.

suchriots commented 2 years ago

It looks like the names of the files on protonvpn also changed now. If I attempt to download a country file from Proton, the filenames have been renamed "us.protonvpn.net.udp" Whereas the github configs still have the "us.protonvpn.com.udp". Not sure if this, ultimately, matters, but it is a difference I noted.

Also, as haasanen noted, when checking the contents, it seems there is still a major difference between what is in the country file, vs what I am downloading today from Proton. The files from Proton have no FQDN entries in them, just IP addresses for the remote portion. So you may want to check your files again.

Forage commented 2 years ago

It looks like the names of the files on protonvpn also changed. If I check the country files, the filenames have been renamed "us.protonvpn.net.udp" Whereas the configs still have the "us.protonvpn.com.udp". Not sure if this, ultimately, matters, but it is a difference I noted. Also, when checking the contents, it seems there is still a major difference between what is in the country file, vs what I am downloading today from Proton. My files have no FQDN entries in them, just IP addresses for the remote portion. So you may want to check your files again.

Already done in #120 (sorry I linked to the wrong PR in your issue, corrected now)

suchriots commented 2 years ago

Thanks Forage. Appreciate you updating these. Any ideas when we can expect the commit? My apologies for missing those when I was looking, but I'm multitasking at the moment.