fix nordvpn ping issue

[marcelrv]

Breaking change

Proposed change

Fixing #240  by re-using the existing environmental variable in this script as well
It uses the HEALTH_CHECK_HOST environment variable if set instead of the fixed to the nordvpn server

Type of change

• [X] Bugfix (non-breaking change which fixes an issue)
• [ ] New provider (thank you!)
• [ ] Updated provider (thank you!)
• [ ] New feature (which adds functionality to a provider script/repo usage)
• [ ] Breaking change (fix/feature causing existing functionality to break)

Additional information

• This PR fixes or closes issue: fixes 240

Checklist

• [X ] The code change is tested and works locally.
• [X ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated

[pkishino]

I’m ok with this, I’ll give it a few days for more comments

[GinoBadouri]

Please merge this, the CDN is unavaileble here: https://downloads.nordcdn.com/configs/files I've also reported it here: https://github.com/haugene/docker-transmission-openvpn/issues/2806

[marcelrv]

Thanks

[oconnoob]

It appears using the edge tag in compose as mentioned in the dockerhub readme doesn't resolve this issue, presumably because the VPN config repo is separate from the main project repo.

Is there any way to incorporate this patch currently, or is it best to wait for a new release on dockerhub? Thanks!

[leewc]

Switching to edge now works, and thanks to: https://github.com/haugene/vpn-configs-contrib/issues/258 as well.

The issue I had was what @GinoBadouri mentioned:

the CDN is unavaileble here: https://downloads.nordcdn.com/configs/files

Manually opening https://downloads.nordcdn.com/configs/files on the browser shows a gateway error too.

It took awhile because the logs look fine, but I had to inspect the container with docker inspect <container-id> or docker inspect transmission (if you use compose and have it named as transmission.

Once i see "DNS resolution failed", I just needed to move to edge.

   transmission:
-    image: haugene/transmission-openvpn
+    image: haugene/transmission-openvpn:edge
     container_name: transmission
     restart: unless-stopped
     environment:
@@ -140,6 +140,7 @@ services:
       - NORDVPN_COUNTRY=US
       - NORDVPN_CATEGORY=the_americas
       - NORDVPN_PROTOCOL=udp
+      - HEALTH_CHECK_HOST=github.com
       - OPENVPN_USERNAME=**None**
       - OPENVPN_PASSWORD=**None**
       - OPENVPN_OPTS=--inactive 3600 --ping 10 --ping-exit 60 # Restart if VPN goes down