Update update-port.sh - Githubissues

haugene / vpn-configs-contrib

A collection of configs for various VPN providers

GNU General Public License v3.0

172 stars 739 forks source link

Update update-port.sh #275

Closed marble-sh closed 4 months ago

marble-sh commented 4 months ago

Sometimes the port would be 4 digits and this script would fail.

also fix some shellcheck errors:

SC2015: A && B || C != if-then-else
SC2086: Double-quotes to prevent globbing/splitting
SC2106: break inside subshell
SC2181: check exit code directly
SC2004: $/${} inside arithmetic
SC1091: cannot follow file (silenced)

I also changed the following:

normalized whitespace
use --json and jq to parse output
move complex things to functions
changed some echo statements
normalize if with test

added a very pretty box output style (includes color!):

╭─────────────────────────────╮
│ The Forwarded Port is: 1180 │
╰─────────────────────────────╯

Breaking change

Proposed change

Fix the update-port.sh script to handle 4-digit ports.

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New provider (thank you!)
[ ] Updated provider (thank you!)
[ ] New feature (which adds functionality to a provider script/repo usage)
[ ] Breaking change (fix/feature causing existing functionality to break)

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue: relates to #
Link to documentation updated (if done separately): https://...

Checklist

[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated

pkishino commented 4 months ago

Looks good. Nice additions.